Todd Lipcon has posted comments on this change. Change subject: KUDU-2066. Add experimental Gradle build support ......................................................................
Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/7258/7/java/gradle/shadow.gradle File java/gradle/shadow.gradle: Line 21: tasks.remove(knows) // Remove "easter egg" knows task. what's this? tried googling but couldn't find it PS7, Line 45: project.conf2ScopeMappings.addMapping( : MavenPlugin.COMPILE_PRIORITY + 1, : configurations.compileUnshaded, : Conf2ScopeMappingContainer.COMPILE : ) not understanding this part at all http://gerrit.cloudera.org:8080/#/c/7258/7/java/gradle/wrapper/gradle-wrapper.jar File java/gradle/wrapper/gradle-wrapper.jar: the ASF is against checking in binary jars http://gerrit.cloudera.org:8080/#/c/7258/7/java/gradlew.bat File java/gradlew.bat: Line 1: @if "%DEBUG%" == "" @echo off can we add these files to the RAT excludes file? http://gerrit.cloudera.org:8080/#/c/7258/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java: Line 35: @Ignore why is this change in here? if you want to disable a test please do it in a separate unrelated commit. http://gerrit.cloudera.org:8080/#/c/7258/7/java/kudu-spark/build.gradle File java/kudu-spark/build.gradle: Line 40: } else { is it possible to be explicit about == "2" and then give a build error if it is anything else? Line 50: } else { same -- To view, visit http://gerrit.cloudera.org:8080/7258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
