Todd Lipcon has posted comments on this change. Change subject: thirdparty: use ninja when possible ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7461/1//COMMIT_MSG Commit Message: PS1, Line 10: less ugly output. > What's the difference here? And is it still less ugly when outputting to so yea, with parallel builds, it buffers output in such a way that avoids interleaving http://gerrit.cloudera.org:8080/#/c/7461/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 54: # If ninja is on the path, use that instead of make for a slightly > Would prefer if this happened in build-thirdparty.sh; this file only defin Done Line 56: if which ninja > /dev/null ; then > RHEL installs ninja as ninja-build, perhaps you should add a case for that. Done Line 97: build_cmake() { > What about here? If it can't work, add a comment explaining why? Done -- To view, visit http://gerrit.cloudera.org:8080/7461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idacd6d8bc9ad371c3c925f7c628ad69785bb870e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
