Todd Lipcon has posted comments on this change. Change subject: Expose running maintenance op info ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7537/2/src/kudu/util/maintenance_manager.h File src/kudu/util/maintenance_manager.h: PS2, Line 245: nstances of this op > The instances are created by the caller of AddRunningInstance(), and need t yea, I wouldn't worry about contention on that lock, since you'd only be holding it while adding/removing entries (not while _running_ the op). Given that we only start/finish ops a few times per second (maybe 10-20 if you have lots of threads) it's still super low-contention as far as these things go. -- To view, visit http://gerrit.cloudera.org:8080/7537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide228d7e70deae3ae89d108cbd270f3f0f2580ca Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <samuel.okr...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sam Okrent <samuel.okr...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
