Adar Dembo has posted comments on this change. Change subject: consensus_peers: capture weak refs in functors submitted to thread pools ......................................................................
Patch Set 3: > Maybe worth looping raft_consensus-itest a bunch before committing > if you have a few minutes. I looped it 1000 times. Wound up with a couple instances of KUDU-2088 as well as a few other unusual errors which can be seen here: https://gist.github.com/adembo/3c92e33e9969974b1f02be13f23bdcc4. I don't believe these errors were due to this patch as lifecycle issues typically manifest as crashes. So I'm going to merge this. -- To view, visit http://gerrit.cloudera.org:8080/7543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dbb777e7e141f1f5bf48026779f1d4b26185195 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No