Sandish Kumar HN has posted comments on this change.

Change subject: kudu client tools for hadoop and spark 
import/export(csv,parquet,avro)
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7421/5/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
File 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java:

Line 99:       if (!schema.containsField(columnSchema.getName())) {
Kudu has primitive-types, parquet has just Type. Example: In Kudu binary type 
and in parquet its string type. How can I compare ?. please give some idea on 
this??


Line 100:         LOG.error("The column " + columnSchema.getName() + " does not 
exists in parquet schema");
what should I use instead of system.exit(0). just LOG.error("") enough??


-- 
To view, visit http://gerrit.cloudera.org:8080/7421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If462af948651f3869b444e82151c3559fde19142
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN <sanysand...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sandish Kumar HN <sanysand...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to