Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks ......................................................................
KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks This fixes a bug when seeking past the last element of a prefix-encoded binary block. In very specific circumstances, described in the JIRA, this would cause a Status::Corruption() to be returned. Prior to the fix, the updated test would fail pretty reliably when looped 50-100 times. With the patch, I looped it 1000 times with no failure. Change-Id: I1670b2244d586e4920f0603c48f65ed993a3b12b Reviewed-on: http://gerrit.cloudera.org:8080/7545 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves <davidral...@gmail.com> Reviewed-by: Andrew Wong <aw...@cloudera.com> --- M src/kudu/cfile/binary_prefix_block.cc M src/kudu/cfile/encoding-test.cc 2 files changed, 48 insertions(+), 9 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Andrew Wong: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1670b2244d586e4920f0603c48f65ed993a3b12b Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>