Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass ......................................................................
Patch Set 11: -Verified > (19 comments) > > Thanks for banging on this some more, will be great to have with > the automated checking. I only got through about 40%, but I saw a > lot of repeated patterns that are kind of suspicious. Basically > most uses of the pragmas surprised me. Are these pragmas > indicating issues with IWYU, or with our includes? In particular > logging.h, port.h, and boost headers keep reappearing. Thank you for taking a look at this. The automated checking is coming -- I added the script to mute warnings for some files in a separate changelist and I'm planning to include it into a pre-commit build. I just was hoping to remove as many files from the mute list as possible for now. Yes, those pragmas manifest issues with IWYU -- it's still in alpha quality, if not lower. The pattern with <glog/logging.h> is a re-occurring one, and there are many more like that. And there are even worse ones, which breaks compilation. The problem is that I don't know how to automate the process of straighten it up, and it requires a lot of manual intervention (that's why so much time is spent on that already). The only hope is to try mappings for the boost headers -- that type of suggestions might be straighten up as documented. As for <glog/logging.h> -- I tried a mapping with previous version of the IWYU tool, but no luck. I'll add a link about the pragmas into the commit message, sure. -- To view, visit http://gerrit.cloudera.org:8080/4738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
