Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7618
Change subject: Add tablet state summary metrics and fix KUDU-2044 ...................................................................... Add tablet state summary metrics and fix KUDU-2044 This patch adds metrics for the number of tablets in each state (i.e. the number of tablets for each value of TabletStatePB). The numbers are computed by the heartbeater. There's two reasons for this: 1. the heartbeater was already computing the number of RUNNING and BOOTSTRAPPING tablets by holding the appropriate lock and iterating over the tablet map 2. the alternative to having some thread periodically iterate over the tablet map is to increment and decrement the metrics when tablets transition states. This is error-prone, particularly if new states are added, and mistakes will accumulate until the metric is worse than useless. It also addresses KUDU-2044: tombstoned tablets will no longer produce metrics in /metrics output. A metric entity can now be marked as hidden, so it will not print to /metrics, and tablet metric entities are marked as hidden when the tablet is tombstoned, and un-hidden if and when the tablet is revived. Change-Id: I8c82987ffe4f37e8af95972bde97841e44c521d9 --- M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/tablet/tablet.cc M src/kudu/tserver/heartbeater.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/util/metrics.cc M src/kudu/util/metrics.h 8 files changed, 249 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/7618/1 -- To view, visit http://gerrit.cloudera.org:8080/7618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8c82987ffe4f37e8af95972bde97841e44c521d9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
