Alexey Serbin has posted comments on this change. Change subject: [gutil] remove the rest of 'using ...' from headers ......................................................................
Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/hash/hash.h File src/kudu/gutil/hash/hash.h: Line 97: namespace __gnu_cxx { > warning: invalid case style for namespace '__gnu_cxx' [readability-identifi Ignoring this due to obvious reasons. Line 212: namespace __gnu_cxx { > warning: invalid case style for namespace '__gnu_cxx' [readability-identifi ditto Line 403: namespace __gnu_cxx { > warning: invalid case style for namespace '__gnu_cxx' [readability-identifi ditto http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/strings/join.h File src/kudu/gutil/strings/join.h: Line 10: #include <stdio.h> > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/strings/serialize.cc File src/kudu/gutil/strings/serialize.cc: Line 5: #include <stddef.h> > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/strings/serialize.h File src/kudu/gutil/strings/serialize.h: Line 10: #include <string.h> > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/strings/split.cc File src/kudu/gutil/strings/split.cc: Line 25: using std::iterator_traits; > warning: using decl 'iterator_traits' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/strings/split.h File src/kudu/gutil/strings/split.h: Line 23: #include <stddef.h> > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/7649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
