Grant Henke has posted comments on this change. Change subject: WIP: support for running Java tests in dist-test ......................................................................
Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/7579/1//COMMIT_MSG Commit Message: Line 10: one of the tests is still failing when run in this environment, but What's failing? I would be happy to help with this. http://gerrit.cloudera.org:8080/#/c/7579/1/build-support/run_dist_test.py File build-support/run_dist_test.py: Line 200: # i.e the presence of the '.gradle' in the user's home directory outside of the Kudu You can set the GRADLE_USER_HOME environment variable, gradle.user.home system property, or --gradle-user-home command line parameter to change where the .gradle is placed. Would that help? I am not sure I grok the issue. http://gerrit.cloudera.org:8080/#/c/7579/1/java/build.gradle File java/build.gradle: Line 51: task distTest(type: DistTestTask) { Would adding this task to the `tests.gradle` file make sense? Its already applied to each subproject. http://gerrit.cloudera.org:8080/#/c/7579/1/java/gradle/shadow.gradle File java/gradle/shadow.gradle: Line 110: } Nit. White space. http://gerrit.cloudera.org:8080/#/c/7579/1/java/gradle/tests.gradle File java/gradle/tests.gradle: Line 25 Nit. Move this comment about the testLogging line now. Line 83: check.dependsOn(integrationTest) Nit. White space. http://gerrit.cloudera.org:8080/#/c/7579/1/java/kudu-flume-sink/src/test/resources/testAvroKuduOperationsProducer.avsc File java/kudu-flume-sink/src/test/resources/testAvroKuduOperationsProducer.avsc: Line 1: {"namespace": "org.apache.kudu.flume.sink", Looks like this exists already here: java/kudu-flume-sink/src/test/avro/testAvroKuduOperationsProducer.avsc Does it need to be moved? -- To view, visit http://gerrit.cloudera.org:8080/7579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I163c3d88b0cfbb6c2aa9af3af5a308c4196c0451 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
