Hello David Ribeiro Alves, Jean-Daniel Cryans, I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7661 to review the following change. Change subject: python: restore setuptools requirement and employ different workaround ...................................................................... python: restore setuptools requirement and employ different workaround Commit d0acb55 moved the installation of setuptools from requirements.txt to build-and-test.sh itself. This is somewhat inconvenient, and it reduces the usefulness of requirements.txt; it's no longer a "one stop shop" for all dependencies needed to build the Python bindings. The build problems we saw were due to a virtualenv like so: 1. Initially, an old pip and setuptools 2. An upgraded pip (via `pip install --upgrade pip` in build-and-test.sh) When `pip install -r requirements.txt` is run with such a virtualenv, the new pip tries to upgrade the old setuptools and is unable to do so. Let's try a different approach: let's not upgrade pip at all. We'll start with whatever pip/setuptools are in the virtualenv, and we'll use that pip to upgrade setuptools via the usual `pip install -r requirements.txt`. This appears to work on both CentOS 6.6 and Ubuntu 16.04. On CentOS 6.6 I tested with both python-virtualenv 1.7.2 (which initializes a virtualenv with pip 1.1 and setuptools 0.6c11) and 1.10.1 (pip 1.4.1 and setuptools 0.9.8). Change-Id: I1a8947bc8e89ec73728749bbcc6e9b919e26838a --- M build-support/jenkins/build-and-test.sh M python/requirements.txt 2 files changed, 24 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/7661/1 -- To view, visit http://gerrit.cloudera.org:8080/7661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1a8947bc8e89ec73728749bbcc6e9b919e26838a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>