Adar Dembo has posted comments on this change. Change subject: [thirdparty]: added include-what-you-use ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7593/3/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: PS3, Line 264: fetch_and_expand include-what-you-use-${IWYU_VERSION}.src.tar.gz \ : ${LLVM_SOURCE}/tools/clang/tools Right now updating LLVM involves extracting the LLVM tarball, adding clang and a bunch of other stuff, retarring it, and uploading the result. The new EXTRACT_SUBDIR functionality you added to fetch_and_expand means we could perhaps get away with uploading the various LLVM and clang tarballs to S3 and piecing the directory tree together on the client machine, like you did for IWYU. In any case, adding IWYU like this represents an unusual middle ground: the LLVM tarball is not fully preprocessed, nor is it fully postprocessed. Could you either adhere to the status quo and upload a new LLVM tarball to S3 containing IWYU, or redo this to fully componentize LLVM and piece the directory tree together locally? Which approach is preferred may depend on whether IWYU needs to be patched/updated with every LLVM release. Is there some semblance of compatibility? Or is there a 1-1 relationship between each release? -- To view, visit http://gerrit.cloudera.org:8080/7593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I041ad9e4bbff410f1760c7abd8cd173e5e9cc564 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
