Alexey Serbin has posted comments on this change. Change subject: [build-support] added IWYU filter script ......................................................................
Patch Set 6: (4 comments) > (4 comments) > > For the imported mapping files: > - Please add a file-level comment pointing to the source URL (if > applicable). > - Please add the appropriate license. Is it Apache-compatible? > > For mapping files you wrote: > - Add ASL copyright headers as well as file-level comments > explaining the file's purpose. Thank you for the reminder! The license the IWYU comes is a BSD-style one: https://github.com/include-what-you-use/include-what-you-use/blob/master/LICENSE.TXT I added the license file for boost mappings into the directory -- I thought that adding just a link to that file would not be enough. http://gerrit.cloudera.org:8080/#/c/7604/2/build-support/iwyu/iwyu-filter.awk File build-support/iwyu/iwyu-filter.awk: Line 39: # > I see. Maybe that merits an additional comment about IWYU being a static an It's a good idea -- I'll add that notion. http://gerrit.cloudera.org:8080/#/c/7604/5/build-support/iwyu/iwyu-filter.awk File build-support/iwyu/iwyu-filter.awk: PS5, Line 20: IWYU is of alpha quality and > IWYU Done PS5, Line 25: map > don't need Done PS5, Line 28: IWYU) and a f > just IWYU would be enough, I think. Done -- To view, visit http://gerrit.cloudera.org:8080/7604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idae8dae3e488151590d5420adc1f0a084339e2fa Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
