Alexey Serbin has posted comments on this change. Change subject: rpc: some small cleanup in ConnectionId ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7686/1/src/kudu/rpc/proxy.cc File src/kudu/rpc/proxy.cc: PS1, Line 68: set_real_user nit: maybe, it's worth updating the signature of UserCredentials::set_real_user() to fit move semantics as well? -- To view, visit http://gerrit.cloudera.org:8080/7686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0788052f8c943ef102f3f551a85a8b219c65c361 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
