Adar Dembo has posted comments on this change. Change subject: handle disk failures during tablet copies ......................................................................
Patch Set 1: (3 comments) I imagine Mike will do a more thorough review, but overall looks good to me. http://gerrit.cloudera.org:8080/#/c/7654/1//COMMIT_MSG Commit Message: Line 10: receiving data) and the copy session sources (that sending data). "receive" and "send". Or "are receiving" and "are sending". http://gerrit.cloudera.org:8080/#/c/7654/1/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: PS1, Line 525: if (group->uuid_indices().size() != valid_uuid_indices.size()) { : return Status::IOError("Directory group contains a failed directory"); : } : group_uuid_indices = &valid_uuid_indices; Unrelated to this patch? http://gerrit.cloudera.org:8080/#/c/7654/1/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: Line 305: Leftover from a change since removed? Or is this stylistic? -- To view, visit http://gerrit.cloudera.org:8080/7654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic18d93c218ea13f3086f420a4847cb5e29a47bc7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
