Todd Lipcon has posted comments on this change. Change subject: gutil: remove use of deprecated headers ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7684/1/src/kudu/gutil/hash/hash.h File src/kudu/gutil/hash/hash.h: PS1, Line 214: #if defined(__GNUC__) : // Use our nice hash function for strings : template<class _CharT, class _Traits, class _Alloc> : struct hash<std::basic_string<_CharT, _Traits, _Alloc> > { : size_t operator()(const std::basic_string<_CharT, _Traits, _Alloc>& k) const { : return HashTo32(k.data(), static_cast<uint32>(k.length())); : } : }; : : // they don't define a hash for const string at all : template<> struct hash<const std::string> { : size_t operator()(const std::string& k) const { : return HashTo32(k.data(), static_cast<uint32>(k.length())); : } : }; : #endif // defined(__GNUC__) > Does it make sense to remove this as well? I guess this one causes problems when building with libc++ (worked ok with libstdcxx). Will remove and cross fingers :) -- To view, visit http://gerrit.cloudera.org:8080/7684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie088f77aa3f70d386a00166e783c66200fce781b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
