Todd Lipcon has submitted this change and it was merged. Change subject: rpc: move ConnectionId to its own file ......................................................................
rpc: move ConnectionId to its own file This class was previously implemented inside of outbound_call.{cc,h} where it didn't quite belong. In the several years since the code was initially written we've moved more towards a "single class per header" model unless the classes are truly trivial or really tightly coupled. Neither is the case here. Change-Id: I5343c2f6ad305b5927d71457d5d19e3799052ec9 Reviewed-on: http://gerrit.cloudera.org:8080/7685 Reviewed-by: Alexey Serbin <aser...@cloudera.com> Tested-by: Todd Lipcon <t...@apache.org> --- M src/kudu/rpc/CMakeLists.txt A src/kudu/rpc/connection_id.cc A src/kudu/rpc/connection_id.h M src/kudu/rpc/outbound_call.cc M src/kudu/rpc/outbound_call.h M src/kudu/rpc/proxy.h M src/kudu/rpc/reactor.h M src/kudu/rpc/rpc_context.cc 8 files changed, 174 insertions(+), 120 deletions(-) Approvals: Todd Lipcon: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5343c2f6ad305b5927d71457d5d19e3799052ec9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>