Todd Lipcon has posted comments on this change.

Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC 
proxies
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7687/4/src/kudu/master/ts_descriptor.cc
File src/kudu/master/ts_descriptor.cc:

Line 246:   RETURN_NOT_OK(ResolveSockaddr(&addr, &host));
> In cases like this, wouldn't addr.ToStringWithoutPort() be the same as 'hos
addr.ToStringWithoutPort is always the dotted-decimal string '1.2.3.4' rather 
than the original hostname.

The idea of trying to maintain the user-specified host is also to deal with the 
case where the user is using a hostname that doesn't quite match the canonical 
name. krb5 will often canonicalize it for us using reverse DNS (with the 
default config) but we should leave that up to krb5.conf, and respect 
rdns=false if they have configured it that way.


http://gerrit.cloudera.org:8080/#/c/7687/4/src/kudu/util/net/sockaddr.cc
File src/kudu/util/net/sockaddr.cc:

PS4, Line 102:   char str[INET_ADDRSTRLEN];
             :   ::inet_ntop(AF_INET, &addr_.sin_addr, str, INET_ADDRSTRLEN);
             :   return StringPrintf("%s:%d", str, port());
> return StringPrintf("%s:%d", ToStringWithoutPort(), port());
actually just realized that we already have a .host() which is equivalent to 
the new method I added. will just use that.


-- 
To view, visit http://gerrit.cloudera.org:8080/7687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96fb3c73382f0be6e30e29ae2e7176be42f3bb98
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to