Dan Burkert has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7693/4/src/kudu/security/init.cc File src/kudu/security/init.cc: Line 398: std::transform(hostname.begin(), hostname.end(), hostname.begin(), tolower); Does this handle multi-byte characters correctly? Is that necessary for hostnames? -- To view, visit http://gerrit.cloudera.org:8080/7693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ef65dd827459476a2d225d8e3f7c80ff2fdf627 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes