Adar Dembo has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets ......................................................................
Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/7440/12/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS12, Line 753: replica->SetError(s); : replica->Shutdown(); > I'm going to keep it this way since it preserves some useful error messages I don't think you have to lose the error messages: Status s; auto cleanup = MakeScopedCleanup([&]() { replica->SetError(s); replica->Shutdown(); } s = cmeta_manager_->Load(...); if (!s.ok()) { LOG(ERROR) << ...; return; } This way you get a customized log message per error site, but you centralize the cleanup in one place. -- To view, visit http://gerrit.cloudera.org:8080/7440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f61585b02fbe270d215bf7f49c0d390ceee3345 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
