Todd Lipcon has posted comments on this change.

Change subject: consensus: Tablet copy should clear last-logged opid from 
superblock
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7718/3//COMMIT_MSG
Commit Message:

Line 9: Keeping around irrelevant information is bad hygiene.
Mike and I discussed offline... it seems like this might not be a great idea 
after all as implemented here. We want to preserve the ability to vote in a 
case like:

- a new replica is being added
- tablet copy starts
- either the tablet copy source or destination crashes
- cluster restarts, and one of the other two replicas doesn't come back up

Now we have the following replicas:
1) good state
2) crashed / not coming back up
3) failed tablet copy

We want to make sure that replica #3 retains the ability to vote so it can 
elect #1 and repair itself.


-- 
To view, visit http://gerrit.cloudera.org:8080/7718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa84d59c63222e9ddb05dca492f9ecd47b5c63ea
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to