Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states ......................................................................
Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/7270/18/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: Line 328: Status DataDirManager::OpenExisting(Env* env, CanonicalizedRootsList data_fs_roots, > warning: the parameter 'data_fs_roots' is copied for each invocation but on Done Line 348: Status DataDirManager::CreateNew(Env* env, CanonicalizedRootsList data_fs_roots, > warning: the parameter 'data_fs_roots' is copied for each invocation but on Done http://gerrit.cloudera.org:8080/#/c/7270/18/src/kudu/fs/data_dirs.h File src/kudu/fs/data_dirs.h: Line 22: #include <string> > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/7270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifddf0817fe1a82044077f5544c400c88de20769f Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
