Dan Burkert has posted comments on this change.

Change subject: [iwyu] update on the internal and boost mappings
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7696/4/thirdparty/patches/llvm-iwyu-include-picker.patch
File thirdparty/patches/llvm-iwyu-include-picker.patch:

Line 3: @@ -123,6 +123,13 @@ const IncludeMapEntry libc_symbol_map[] = {
Is there any sort of provenance for this patch?  Without a comment saying where 
it's coming from / what it's doing, it's a lot harder to go back and remove it 
later.  Is this diff on track to get upstreamed somewhere?


-- 
To view, visit http://gerrit.cloudera.org:8080/7696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a20616093f362a5b5ae30627b6121313b50efa2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to