Dan Burkert has posted comments on this change. Change subject: [build-support] IWYU build configuration for Jenkins ......................................................................
Patch Set 3: Code-Review+1 (1 comment) LGTM, but I didn't review the python portion. Not sure if that needs to be reviewed, but if it does I'm probably not the best person for it. http://gerrit.cloudera.org:8080/#/c/7750/3/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: Line 275: awk -f ../../build-support/iwyu-filter.awk $IWYU_LOG | tee $IWYU_FILTERED_LOG Just curious - is this post-processing step with awk a common thing to do with IWYU, or is this workaround specific to Kudu? -- To view, visit http://gerrit.cloudera.org:8080/7750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45f2e8529891dd7da18c9fa6383e0c41e6b4182e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
