Adar Dembo has posted comments on this change. Change subject: consensus: use periodic timers for failure detection ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7735/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 252: std::bind([w]() { > same comment about no-arg bind Done Line 319: rng_.Normal(GetFailureMonitorCheckMeanMs(), > This might result in a negative value. It would probably be OK, but since I tried to preserve these semantics to minimize the scope of the patch. And these flags are being used by a couple itests that I didn't really have interest in updating. A negative value here just means the timer will fire immediately, which is safe. Line 533: "Failed to submit failure detected task"); > can you work the log prefix into this? Done http://gerrit.cloudera.org:8080/#/c/7735/2/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: Line 27: #include <boost/none.hpp> > This looks like it may be a bad interaction with Alexey's patch, but I don' I rebased on top of Alexey's patch and now I need neither of these. Strange. Line 523: void EnsureFailureDetectorEnabled( > I think these methods would be better named 'EnableFailureDetector' and 'Di Sure, I don't mind. PS2, Line 529: unregistered > disabled Done -- To view, visit http://gerrit.cloudera.org:8080/7735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8acdb44e12b975fda4a226aa784db95bc7b4e330 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
