Edward Fancher has posted comments on this change. Change subject: KUDU-2033 (part 2). Add test for Java client failover support. ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7722/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java: PS1, Line 58: blic void testMu > Move this closer to the point of the usage. Done PS1, Line 60: > Is it crucial to have that suffix? I would expect it's not, so consider dr Done PS1, Line 61: getBas > nit: as the builder is not needed in the code below, consider not creating Done Line 85: } > Consider dropping the table in the very end, making sure it can be successf Done -- To view, visit http://gerrit.cloudera.org:8080/7722 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I228e08429d952f0f5b2657e0b8481366c5c572a4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <e...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Edward Fancher <e...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
