Andrew Wong has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets ......................................................................
Patch Set 20: (6 comments) http://gerrit.cloudera.org:8080/#/c/7440/19/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: Line 627: void PeerMessageQueue::NotifyPeerHasFailed(const string& peer_uuid, const string& reason) { > consider: Done PS19, Line 628: l(queue_lo > This should be protected by queue_lock_ Done PS19, Line 632: ignored. > This should be protected by queue_lock_ Done PS19, Line 633: int64_t current_term = queue_st > No need to hold queue_lock_ while calling NotifyObserversOfFailedFollower() Ah I see, thanks for clarifying. http://gerrit.cloudera.org:8080/#/c/7440/19/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: Line 310: // its FAILED state. > nit: add a comment for why we are specifying this flag Done http://gerrit.cloudera.org:8080/#/c/7440/19/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS19, Line 646: > Why this change? I don't think this is necessary or desired. Without your tombstoned voting patch, if the replica has been shut down, consensus will be shut down. -- To view, visit http://gerrit.cloudera.org:8080/7440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f61585b02fbe270d215bf7f49c0d390ceee3345 Gerrit-PatchSet: 20 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
