Todd Lipcon has posted comments on this change. Change subject: Bump test timeout for flex_partitioning-itest ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7814/1/CMakeLists.txt File CMakeLists.txt: Line 673: set(ARG_TIMEOUT 900) > Can we avoid defining this default value both here and in run-test.sh? Give Yea, I considered doing this (not passing any TIMEOUT if there is nothing set). However I thought it was nice to have the "belt and suspenders" timeout structure here -- if for some reason the KuduTest timeout mechanism gets stuck, it's nice to have ctest applying a timeout as well. This isn't totally academic - we've seen cases where the 'pstack' which comes when a test timeout hits some bug in gdb which makes it hang, and then the entire build fails. So having ctest kill the test 30 seconds later would prevent that. Line 707: # Set the ctest timeout to be a bit longer than the timeout we pass to > Why bother with the ctest timeout at all, given that the run-test.sh timeou yea, see above Line 714: if("${CUR_TEST_ENV}" STREQUAL "NOTFOUND") > does if(NOT CUR_TEST_ENV) work? ah, I think it might, will try that. -- To view, visit http://gerrit.cloudera.org:8080/7814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07661415d3500dfa5d7984b720b7a6f14597cc19 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
