Adar Dembo has posted comments on this change. Change subject: KUDU-1544: Race in Java client's AsyncKuduSession.apply() ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7839/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: Line 549: Deferred<Void> notification = flushNotification.get(); Any particular reason not to call flushNotification.get() just once a scope or two or three higher, so that the same local can be reused in the activeBuffer != null case? Line 605: null, operation, flushNotification.get()); Here as well? -- To view, visit http://gerrit.cloudera.org:8080/7839 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1791f5ed51e2d79cd9e9bcbf83e9b30eede871b4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
