Alexey Serbin has posted comments on this change. Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7850/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java: Line 90: private int kdcPort; > we need the var so that if we stop and restart the kdc (eg in some kind of ok -- that would be a little fragile (something else could occupy the port in between), but it seems we have the same behavior in C++ tests. Line 177: createKrb5Conf(); > nope, it's only read by the KDC itself (follownig the example of the C++ co If I'm not mistaken, in C++ we actually rewrite the kdc.conf as well. So, from that standpoint I would consider doing the same here. -- To view, visit http://gerrit.cloudera.org:8080/7850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e75d89616e6dbca6e8687eeb23f807c3c7eb952 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
