Adar Dembo has posted comments on this change.

Change subject: KUDU-2113 SEGV because of consensus conflict and missing tablet 
server
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7864/2//COMMIT_MSG
Commit Message:

PS2, Line 7: SEGV
Nit: pedantry, but "SEGV" isn't really a thing. It's either a "segmentation 
fault" or "segfault" (a specific kind of illegal memory access) or a "SIGSEGV" 
(the signal delivered to the process by the kernel due to a segfault, which 
causes it to terminate abnormally).


http://gerrit.cloudera.org:8080/#/c/7864/2/src/kudu/tools/ksck.h
File src/kudu/tools/ksck.h:

PS2, Line 293:   FRIEND_TEST(KsckTest, TestMismatchedAssignments);
             :   FRIEND_TEST(KsckTest, TestConsensusConflictExtraPeer);
             :   FRIEND_TEST(KsckTest, TestConsensusConflictMissingPeer);
             :   FRIEND_TEST(KsckTest, TestConsensusConflictDifferentLeader);
             :   FRIEND_TEST(KsckTest, 
TestMasterNotReportingTabletServerWithConsensusConflict);
Nit: mind sorting this list alphabetically?


-- 
To view, visit http://gerrit.cloudera.org:8080/7864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to