Alexey Serbin has posted comments on this change. Change subject: [iwyu] fix on <ext/alloc_traits.h> ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7867/2/build-support/iwyu/mappings/libstdcpp.imp File build-support/iwyu/mappings/libstdcpp.imp: PS2, Line 18: { include: ["<ext/alloc_traits.h>", private, "<memory>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<condition_variable>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<unordered_map>", public ] }, : { include: ["<ext/alloc_traits.h>", private, "<unordered_set>", public ] } > Makes sense. In gcc 5.4 <string> would also work (via basic_string.h). Or < Thank you for digging out those. I also looked at those for my gcc 5.4.0 at my osx laptop and added <future> header as well. Now we should assume the list is more accurate than the original one. -- To view, visit http://gerrit.cloudera.org:8080/7867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
