Alexey Serbin has posted comments on this change. Change subject: tablet copy: Allow voting from failed initial tablet copies ......................................................................
Patch Set 3: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/7904/2//COMMIT_MSG Commit Message: PS2, Line 7: A > Hrm. This is easy to change but I'm not sold on it and I think this type of It was just a nit, feel free to ignore. I don't think it's worth to enforce some guidelines here, just thought it was a typo. http://gerrit.cloudera.org:8080/#/c/7904/2/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: PS2, Line 1142: int new_replica_idx = cluster_->tablet_server_index_by_uuid(new_replica_uuid); > Yes, because we are explicitly calling AddServer() to do that. ok, thanks. PS2, Line 1156: cluster_->tablet_server(i)->mutable_flags()->pop_back(); > This isn't the first test to use this idiom. If that implementation was cha SGTM. http://gerrit.cloudera.org:8080/#/c/7904/2/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: PS2, Line 316: MakeOpId(1, 0); > MinimumOpid() is defined as (0,0) and that will not work because we conside SGTM -- I just wanted to understand why MinimumOpId() would not fit here. -- To view, visit http://gerrit.cloudera.org:8080/7904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibaad2f56797db731a0f701bbd37e3e450bc17b51 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
