Mike Percy has posted comments on this change. Change subject: consensus: Save previous last-logged OpId across tablet copies ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7888/4/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: PS4, Line 2884: int follower_idx = cluster_->tablet_server_index_by_uuid(follower_uuid); : ASSERT_OK(inspect_->CheckTabletDataStateOnTS(follower_idx, tablet_id_, { TABLET_DATA_COPYING })); : : ASSERT_OK(cluster_->master()->Restart()); : ASSERT_OK(cluster_->tablet_server_by_uuid(leader_uuid)->Restart()); : ASSERT_OK(cluster_->tablet_server_by_uuid(follower_uuid)->Restart()); > is there a way to assert that the follower doesn't have a last op id? It will in this case, and we do assert on it functionally, because if it didn't then the new leader would not get elected and be able to tablet copy over the follower, and we would not be able to write to the tablet again below. -- To view, visit http://gerrit.cloudera.org:8080/7888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie886764adbdc6d84406df44d6cdb693d038bcd57 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
