Dan Burkert has posted comments on this change.

Change subject: docs: light editing on 1.5 release notes; spark security docs
......................................................................


Patch Set 2:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/7914/1/docs/release_notes.adoc
File docs/release_notes.adoc:

PS1, Line 72: a 
> remove
Done


PS1, Line 97: was 
> nit: is
Done


PS1, Line 113: Tablet Server
> nit: it seems, at least in this doc, that we're standardizing to lower-case
Done


PS1, Line 119: Tablet Server
> same here?
Done


PS1, Line 139: * Kudu 1.0 clients may connect to servers running Kudu 1.5 with 
the exception of the
             :   below-mentioned restrictions regarding secure clusters.
> nit: maybe move one down so "below-mentioned" refers to the blob immediatel
Done


http://gerrit.cloudera.org:8080/#/c/7914/2/docs/release_notes.adoc
File docs/release_notes.adoc:

PS2, Line 64: beteween
> between
Done


PS2, Line 72: values
> nit: maybe replace with one of parameters/properties/settings?
Done


PS2, Line 84: functionality
> functionalities
I think both are correct, functionality can cover many items in American 
english.


PS2, Line 124: * The Java Kudu client now automatically requests new 
authentication tokens
             :   after expiration. So, long-lived Java clients are now 
supported. See
             :   
link:https://issues.apache.org/jira/browse/KUDU-2013[KUDU-2013] for more
             :   details.
> Should this be moved under the 'Fixed Issues' instead?
Yah good catch.


-- 
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49014dda6fcec328b3adf3a414ee334ab411e94f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to