Mike Percy has posted comments on this change. Change subject: Implement a lock table ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7918/1/src/kudu/util/lock_table.h File src/kudu/util/lock_table.h: Line 42: boost::optional<std::shared_ptr<LockTableToken<T>>> TryLock(T key) { > Seems simpler to just return type std::shared_ptr<LockTableToken<T>>, with Good idea. -- To view, visit http://gerrit.cloudera.org:8080/7918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0404478675e079ba147fbdb4b0bac9db0cdc87e5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
