Mike Percy has posted comments on this change. Change subject: Add "make tidy" target ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7917/2/CMakeLists.txt File CMakeLists.txt: Line 1117: add_custom_target(tidy ${BUILD_SUPPORT_DIR}/clang_tidy_gerrit.py -n HEAD) > Would be nice to use get-upstream-commit.sh to figure out the exact set of I agree it would be nice, but this is better than what we have today, and I have more pressing tasks at the moment. http://gerrit.cloudera.org:8080/#/c/7917/2/README.adoc File README.adoc: Line 263: === Running clang-tidy checks > +1 I am feeling generous, but not that generous right now, so let's do that in a follow up commit. ;) -- To view, visit http://gerrit.cloudera.org:8080/7917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77ab0376042b7ac754a24ebc7e18bcd6dc240011 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
