Adar Dembo has posted comments on this change. Change subject: master: always use smart pointers when accessing TableInfo and TabletInfo ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7909/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS2, Line 1788: map<string, scoped_refptr<TabletInfo>> > nit: would TabletInfo::TabletInfoMap be a better choice here? Done PS2, Line 1789: map<string, scoped_refptr<TabletInfo>> > ditto Done PS2, Line 3683: .get() > nit: it seems this might be dropped Done PS2, Line 3684: .get() > ditto Done -- To view, visit http://gerrit.cloudera.org:8080/7909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c74f2aa048ee85cc3a5f863ce8f38147e78c5ae Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
