Alexey Serbin has posted comments on this change.

Change subject: [doc] add info about the iwyu target
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7928/1/README.adoc
File README.adoc:

PS1, Line 267: consistent
> Maybe put something else here? The rendered view says "For more information
Done


PS1, Line 269: You can run the IWYU checks via the cmake-generated target 
`iwyu`.  E.g.,
             : once generated makefiles for make, you can run the IWYU 
verification executing
> How about copying the make ilint instructions and saying "You can run the I
Done


PS1, Line 277: This will scan all relevant dirty files in your working tree, 
and files
             : changed since the last committed upstream changelist.
> Likewise, copy the verbiage from make ilint.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87da493486500cde0cd226614f8a19985d295a96
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to