Todd Lipcon has posted comments on this change.

Change subject: docs: update disk failure recovery notes
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7984/1/docs/administration.adoc
File docs/administration.adoc:

Line 597: empty all of the server's existing directories. For example, if a 
tablet server
do you think a WARNING bar is appropriate here? I wonder if someone would 
follow these directions without making sure they have other good replicas or 
backups of their data?


PS1, Line 608: along with any newly-added data
             : directories
you mean 'and new data directories have been created with appropriate 
permissions' or something?


PS1, Line 630: suicide_on_eio=false`. When set, tablets with data on a failed 
disk
             : will not be opened and will be re-replicated as necessary
given that we are currently defaulting to spreading tablets across all disks, 
is this really relevant? ie this would start up with no tablets, but still have 
a bunch of data on those disks?

I also wonder whether we should be documenting this flag considering it is 
tagged experimental. Also I wonder if some people may find the name 
offensive/upsetting and we short rename to 'abort_on_eio'?


-- 
To view, visit http://gerrit.cloudera.org:8080/7984
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I732286d0f56f7a15705ad544fc7dfc426287714e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to