Mike Percy has posted comments on this change.

Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't 
exist at startup
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7988/2//COMMIT_MSG
Commit Message:

PS2, Line 7: replicas
> Nit: replica
If the cmeta doesn't exist


PS2, Line 11: Not having a cmeta
            : file results in those tombstoned replicas being unable to vote in 
Raft
            : leader elections
> Given the conditions you spelled out in the previous sentence, it seems lik
Due to previous versions of Kudu generating many of these kinds of tombstoned 
replicas under load, it's not that rare. Additionally, we don't want them to 
show up as FAILED in the UI, so not making them as FAILED was the primary 
motivation, and being able to vote is really something of a side benefit.


PS2, Line 27: ConsensConsensusMetadataManager
> ConsensusMetadataManager
erg, my Vim auto-wrapping keeps doing this in Git messages. I need to figure 
out why, just haven't got around to it.


PS2, Line 33: thethe
> the
same, thanks


-- 
To view, visit http://gerrit.cloudera.org:8080/7988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ff6255b1fcbb12417b82853bcde9b239291492b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to