Mike Percy has submitted this change and it was merged. Change subject: Fix flakiness of ts_tablet_manager_itest TestFailedTabletsAreReplaced ......................................................................
Fix flakiness of ts_tablet_manager_itest TestFailedTabletsAreReplaced TestFailedTabletsAreReplaced manually fails the replica after only verifying that the tablet exists, with no regard for its state. This can cause the replica's bootstrap process to fail a check: F0907 00:05:46.153576 2697 tablet_replica.cc:173] Check failed: BOOTSTRAPPING == state_ (0 vs. 2) This is a test-only race where the replica successfully goes through the bootstrap process, the tablet is failed in test, and TabletReplica::Start() is called on the replica, which requires its state to be BOOTSTRAPPING. This is not an issue seen in production, as bootstrapping is normally only run if the replica is not failed, but it did result in 6/1000 failures when run in release mode with --stress_cpu_thres=32. To fix this, the replica is failed only after it is verified to be running. In doing so, the number of failures went from 6/1000 to 0/1000. Change-Id: I93b41c8196397ea5af42ed9e2aa47e967f7a520e Reviewed-on: http://gerrit.cloudera.org:8080/7993 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <a...@cloudera.com> Reviewed-by: Hao Hao <hao....@cloudera.com> Reviewed-by: Mike Percy <mpe...@apache.org> --- M src/kudu/integration-tests/ts_tablet_manager-itest.cc 1 file changed, 16 insertions(+), 7 deletions(-) Approvals: Hao Hao: Looks good to me, but someone else must approve Mike Percy: Looks good to me, approved Adar Dembo: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93b41c8196397ea5af42ed9e2aa47e967f7a520e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
