Todd Lipcon has posted comments on this change. Change subject: block_id: use a better hash function ......................................................................
Patch Set 1: I tried making a unit test and weirdly in my unit test environment, the new hash was actually worse than the old one. I also tried reverting this but leaving my other optimizations, and it turns out in the presence of the other fixes around refcounting, etc, and using sparsepp instead of sparsehash, this doesn't make a difference. So, I'll abandon for now. -- To view, visit http://gerrit.cloudera.org:8080/8001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30717955f962957d109a6403b55d59ab6c446a87 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
