Adar Dembo has posted comments on this change. Change subject: log_block_manager: switch from google::sparse_hash_map to sparsepp ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8007/1//COMMIT_MSG Commit Message: Line 14: This improved startup time 7-8x on a real host with ~11M blocks: To be clear, this improvement is just from switching to sparsepp? Or with the other optimizations rolled in? http://gerrit.cloudera.org:8080/#/c/8007/1/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: PS1, Line 328: SPARSEPP_PATCHLEVEL=0 : delete_if_wrong_patchlevel $SPARSEPP_SOURCE $SPARSEPP_PATCHLEVEL : if [ ! -d "$SPARSEPP_SOURCE" ]; then : fetch_and_expand sparsepp-${SPARSEPP_VERSION}.tar.gz : pushd $SPARSEPP_SOURCE : touch patchlevel-$SPARSEPP_PATCHLEVEL : popd : fi If there's not one patch, you can omit the patchlevel-0 boilerplate, as well as the call to delete_if_wrong_patchlevel. http://gerrit.cloudera.org:8080/#/c/8007/1/thirdparty/vars.sh File thirdparty/vars.sh: Line 193: # (from https://github.com/toddlipcon/sparsepp) Why are we pulling from your fork of sparsepp and not the main repo? Have you patched it? -- To view, visit http://gerrit.cloudera.org:8080/8007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7397f9cd418782caecf8b2dae2c7bfe2c0e6215c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
