[kudu-CR] WIP: pb util: avoid repeated stat() calls reading files

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: WIP: pb_util: avoid repeated stat() calls reading files
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8010/1/src/kudu/util/pb_util.cc
File src/kudu/util/pb_util.cc:

PS1, Line 260:   if (!*cached_file_size) {
             :     RETURN_NOT_OK(reader->Size(&file_size));
             :     *cached_file_size = file_size;
             :   } else {
             :     file_size = cached_file_size->get();
             :   }
Nit: invert for clarity?


Line 355:   RETURN_NOT_OK(reader->Size(&file_size));
What about this call?


-- 
To view, visit http://gerrit.cloudera.org:8080/8010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27371800604bcb20bafae7946d3b3e84af094598
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes