Dan Burkert has posted comments on this change. Change subject: KUDU-2137: protect against concurrent schema version change and tablet drop ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7996/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 4318: // locks are acquired before spinlocks. > Perhaps you could grab the partition info before taking the spin locks? Sh To be clear, something like this: string partition_key_start; { TabletMetadataLock l(this, TabletMetadataLock::READ); key_start = metadata().state().pb.partition().partition_key_start(); } std::lock_guard<rw_spinlock> table_l(table_->lock_); std::lock_guard<simple_spinlock> tablet_l(lock_); ... -- To view, visit http://gerrit.cloudera.org:8080/7996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I371fc310a97ae94ec2ebf04405db99c5f2937e1a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
