Adar Dembo has posted comments on this change. Change subject: catalog_manager: fix unprotected data access in TableInfo::AddRemoveTablets ......................................................................
Patch Set 2: > yikes. does this indicate a lack of test coverage around > concurrent alter and tablet drops? The lack of read locks when > creating tablets seems benign since those won't be visible, but the > concurrent increment schema / decrement schema that could happen > from dropping and altering a tablet at once seems like a big race. Not sure I follow the race; aren't the increment/decrement schema operations protected by the table spinlock? The tablet's reported schema version is in-memory only so it's not protected by the tablet metadata lock, just by its spinlock (and the table spinlock, for the subsequent increment/decrement operations). -- To view, visit http://gerrit.cloudera.org:8080/7995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcc5d3a9b985210f1fdd6f0495326fa3eb707841 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No