Adar Dembo has posted comments on this change. Change subject: [tests] de-flaking catalog_manager_tsk-itest ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8017/1//COMMIT_MSG Commit Message: Did you try looping this test with the recent failure-detection change (https://github.com/apache/kudu/commit/21b0f3d5e255760535e281efe5879fe657df1f1c) reverted? Todd suspected that it made elections converge more slowly, and it could be responsible for the flakiness here too. If it is responsible, it'd be better to address that than to continually tweak the test values ever so slightly to ensure it passes. http://gerrit.cloudera.org:8080/#/c/8017/1/src/kudu/integration-tests/catalog_manager_tsk-itest.cc File src/kudu/integration-tests/catalog_manager_tsk-itest.cc: Line 64: hb_interval_ms_(128), I get the feeling that, although these values may now be carefully tuned so that the test passes, that may change as Kudu continues to evolve, at which point we'll burn more time on deflaking it. Why exactly does this test need so many overridden values? Are they required for the test in some way? Or can any be reverted back to the defaults? -- To view, visit http://gerrit.cloudera.org:8080/8017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50cee27a579cffa7232137c7039b02a1ad4ab7eb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
