Adar Dembo has posted comments on this change. Change subject: docs: clarify steps for removing master from multi-master deployment ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8032/1/docs/administration.adoc File docs/administration.adoc: Line 374: ==== Removing masters from a Multi-Master Deployment > Done. I don't know; I think you should ask Mike for clarification. I don't think ksck can tell you which master is most 'up-to-date'. http://gerrit.cloudera.org:8080/#/c/8032/2/docs/administration.adoc File docs/administration.adoc: Line 379: WARNING: in planning the new multi-master configuration, keep in mind that the number of masters Nit: other WARNING text begins with a capital letter. Below too. PS2, Line 382: WARNING: dropping the number of masters below the number of masters currently needed for a Raft : majority can incur data loss. Please double check this with Mike. PS2, Line 392: masters > nit: master nodes? I don't really understand why this instruction is worth including. Yes, it makes sense to ensure that the masters that you're removing aren't going to come back. But I think that's sort of implicit in these instructions, especially in the "Remove the directories..." step. If you look at the other master workflows, none of them call this out explicitly, so at the very least, this workflow ought to be consistent with them. -- To view, visit http://gerrit.cloudera.org:8080/8032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4196dbb2f8a185e868a6906c7cf917d79c404c0d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
