Adar Dembo has submitted this change and it was merged. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them ......................................................................
c++ client: try harder to pass table IDs into RPCs that can accept them Some RPCs (such as IsCreateTableDone or IsAlterTableDone) can identify a table by name or by ID. Using an ID is more robust since it's globally unique and immutable. This patch changes several RPC calls to use table IDs. Note: table IDs were only added to AlterTableResponsePB in Kudu 0.10. By using them here, the C++ client may crash when altering tables belonging to an older deployment. Change-Id: I0052d18f714aee1226b96bf1da9defa5738fdd37 Reviewed-on: http://gerrit.cloudera.org:8080/8066 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> Reviewed-by: David Ribeiro Alves <[email protected]> --- M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/master_failover-itest.cc 6 files changed, 113 insertions(+), 60 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Alexey Serbin: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0052d18f714aee1226b96bf1da9defa5738fdd37 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
